Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update PR checklist #4909

Merged

Conversation

Manciukic
Copy link
Contributor

@Manciukic Manciukic commented Nov 12, 2024

Changes

Improve the PR checklist to make it more clear and explicitly ask contributors to run the automated checkstyles.

Reason

The current PR checklist doesn't tell to run the checkstyle explicitly and it's a common reason PRs from external contributors get delayed. I also took the opportunity to refresh it.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the automated style checks.
  • I have described what is done in these changes, why they are needed, and how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs) in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@Manciukic Manciukic force-pushed the pr/update_pr_checklist branch from f3612f3 to 42d41db Compare November 12, 2024 16:05
Improve the PR checklist to make it more clear and explicitly ask
contributors to run the automated checkstyles.

Signed-off-by: Riccardo Mancini <[email protected]>
@Manciukic Manciukic force-pushed the pr/update_pr_checklist branch from 42d41db to 3e6563a Compare November 12, 2024 16:08
@Manciukic Manciukic marked this pull request as ready for review November 12, 2024 16:09
@Manciukic Manciukic added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Nov 12, 2024
@Manciukic Manciukic merged commit 5a23130 into firecracker-microvm:main Nov 12, 2024
6 checks passed
@Manciukic Manciukic deleted the pr/update_pr_checklist branch November 12, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants