fix: add vcpu_features and kvm_capabilites to swagger #4921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4921 +/- ##
=======================================
Coverage 84.07% 84.07%
=======================================
Files 251 251
Lines 28067 28067
=======================================
Hits 23597 23597
Misses 4470 4470
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
These fields were added in firecracker-microvm#3967 but the Swagger API definition was not updated. This patch fixes the API definition. Also, the field type is changed from "string" to "object", as it has properties and thus can't be a string. Signed-off-by: Riccardo Mancini <[email protected]>
Manciukic
force-pushed
the
pr/fix-swagger-cpu-config
branch
from
d581272 to
b76bd80
Compare
pb8o
previously approved these changes
Nov 20, 2024
Manciukic
added
the
Status: Awaiting review
ShadowCurse
reviewed
Nov 20, 2024
Add an entry to mention that we fixed the Swagger API definition. Signed-off-by: Riccardo Mancini <[email protected]>
Manciukic
force-pushed
the
pr/fix-swagger-cpu-config
branch
from
9f875c9 to
11cf18d
Compare
ShadowCurse
approved these changes
Nov 21, 2024
pb8o
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
CpuConfigReason
These fields were added in #3967 but the Swagger API definition was not updated. This patch fixes the API definition.
Also, the field was incorrectly marked as string. I've verified that changing to object doesn't lead to any changes in the generated client code, as it was already considering it as an object.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.