Improve network-setup with nft support and further instructions. #4922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Had to remake the PR due to a problem during squashing, unfortunately. All the changes remain the same and I ran |
pb8o
added
Type: Documentation
pb8o
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
It looks like one line in the commit body is too long Could you git commit --amend it? And then git push --force
|
Done (hopefully). |
|
These checkstyle rules are properly annoying... |
- Support for multiple guests - Kernel network configuration using boot arg Signed-off-by: kanpov <[email protected]>
Manciukic
approved these changes
Nov 21, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
network-for-clones is not changed in this PR since it's a whole another can of worms I'd like to deal with later.
These changes are to network-setup:
Migrate to nftables
Improve the documentation itself to convert it from a rather basic getting started guide to something more usable in the real world:
Multiple guests section
Guest kernel configuration at kernel level section (
ipkernel boot arg)Reason
Fulfills #4874
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.