fix: properly setup outbound network connectivity in getting started #4932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypat
requested review from
xmarcalx,
kalyazin,
pb8o and
Manciukic
as code owners
roypat
added
the
Status: Awaiting review
roypat
force-pushed
the
fix-getting-starting
branch
from
8d01d76 to
4fc4880
Compare
kalyazin
reviewed
Nov 28, 2024
pb8o
previously approved these changes
Nov 28, 2024
pb8o
reviewed
Nov 28, 2024
roypat
force-pushed
the
fix-getting-starting
branch
from
4fc4880 to
c14528d
Compare
the getting started guide was hardcoding eth0 as the network interface on the host to route outbound microvm network traffic to. However, on EC2 instances (and my laptop), that's wrong, because its not called eth0. So instead dynamically determine the hopefully correct network interface on the host. Fixes: firecracker-microvm#4930 Suggested-by: Pablo Barbáchano <[email protected]> Signed-off-by: Patrick Roy <[email protected]>
roypat
force-pushed
the
fix-getting-starting
branch
from
c14528d to
19ddd0e
Compare
kalyazin
approved these changes
Nov 28, 2024
pb8o
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the getting started guide was hardcoding eth0 as the network interface on the host to route outbound microvm network traffic to. However, on EC2 instances (and my laptop), that's wrong, because its not called eth0. So instead dynamically determine the hopefully correct network interface on the host.
Suggested-by: Pablo Barbáchano [email protected]
Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.