[CI] Add support for M7a detection in tests #4939
Merged
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4939 +/- ##
=======================================
Coverage 84.07% 84.07%
=======================================
Files 251 251
Lines 28059 28059
=======================================
Hits 23592 23592
Misses 4467 4467
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JackThomson2
force-pushed
the
fix/m7a_test_fixes
branch
from
92f70fa to
6c57147
Compare
JackThomson2
added
the
Status: Awaiting review
pb8o
previously approved these changes
Dec 2, 2024
zulinx86
previously approved these changes
Dec 2, 2024
JackThomson2
force-pushed
the
fix/m7a_test_fixes
branch
from
6c57147 to
d1aaf34
Compare
Add support for detection on m7a instance and prevent the test failure from missing cpu config test Signed-off-by: Jack Thomson <[email protected]>
JackThomson2
force-pushed
the
fix/m7a_test_fixes
branch
from
d1aaf34 to
8c98a14
Compare
pb8o
approved these changes
Dec 3, 2024
roypat
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add support for detection on m7a instance and prevent the test failure from missing cpu config test
Reason
Steps to allow us to run the M7a instance in our CI environment
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.