-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: flesh out the AMD Genoa host vs guest test #4947
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pb8o
added
Type: Bug
Indicates an unexpected problem or unintended behavior
Priority: Medium
Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled
Status: Awaiting author
Indicates that an issue or pull request requires author action
python
Pull requests that update Python code
labels
Dec 6, 2024
Manciukic
previously approved these changes
Dec 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4947 +/- ##
=======================================
Coverage 84.07% 84.07%
=======================================
Files 251 251
Lines 28059 28059
=======================================
Hits 23592 23592
Misses 4467 4467
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
roypat
previously approved these changes
Dec 6, 2024
pb8o
force-pushed
the
fix-test-genoa
branch
2 times, most recently
from
December 6, 2024 12:55
21f7ed9
to
b9b6742
Compare
Manciukic
previously approved these changes
Dec 6, 2024
JackThomson2
previously approved these changes
Dec 6, 2024
pb8o
force-pushed
the
fix-test-genoa
branch
6 times, most recently
from
December 6, 2024 18:02
bbd99db
to
03d822d
Compare
pb8o
added
the
Status: Awaiting review
Indicates that a pull request is ready to be reviewed
label
Dec 6, 2024
pb8o
removed
the
Status: Awaiting author
Indicates that an issue or pull request requires author action
label
Dec 6, 2024
pb8o
changed the title
fix(tests): bring back the AMD Genoa check
fix(tests): flesh out the AMD Genoa host vs guest test
Dec 6, 2024
JackThomson2
approved these changes
Dec 9, 2024
pb8o
removed
the
Type: Bug
Indicates an unexpected problem or unintended behavior
label
Dec 10, 2024
pb8o
changed the title
fix(tests): flesh out the AMD Genoa host vs guest test
tests: flesh out the AMD Genoa host vs guest test
Dec 10, 2024
kalyazin
reviewed
Dec 10, 2024
Record the differences wrt AMD Milan CPUs. Signed-off-by: Pablo Barbáchano <[email protected]>
kalyazin
reviewed
Dec 10, 2024
kalyazin
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Priority: Medium
Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled
python
Pull requests that update Python code
Status: Awaiting review
Indicates that a pull request is ready to be reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Record the differences with AMD Milan CPU.
Reason
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
tools/devtool checkstyle
to verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md
.Runbook for Firecracker API changes.
integration tests.
TODO
.rust-vmm
.