set quadrature degree for forms in equation residual #530
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that we no longer unthinkingly exceed sensible quadrature degree limits. This is achieved by adding a
label_map
to the equation residual in thesetup_equation
method of theTimestepper
class which replaces all of the terms with new terms containing the same form and labels, the only difference being that the integrals in the form have had their metadata updated to contain a quadrature degree of 5.To Do:
max_quad_deg
to other equation setsmax_quad_deg
in initialisation (and diagnostics?)