Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set quadrature degree for forms in equation residual #530

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jshipton
Copy link
Contributor

@jshipton jshipton commented Jul 26, 2024

This PR ensures that we no longer unthinkingly exceed sensible quadrature degree limits. This is achieved by adding a label_map to the equation residual in the setup_equation method of the Timestepper class which replaces all of the terms with new terms containing the same form and labels, the only difference being that the integrals in the form have had their metadata updated to contain a quadrature degree of 5.

To Do:

  • use logging to log an info level warning when the quadrature degree is set
  • add max_quad_deg to other equation sets
  • use max_quad_deg in initialisation (and diagnostics?)

@jshipton jshipton marked this pull request as draft July 26, 2024 14:06
@tommbendall tommbendall added the tidying Pull requests or issues that involve tidying up code label Aug 7, 2024
@tommbendall tommbendall added the optimisation Involves optimising performance of code label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimisation Involves optimising performance of code tidying Pull requests or issues that involve tidying up code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants