-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add offline support #153
base: master
Are you sure you want to change the base?
add offline support #153
Conversation
This commit updates the `webpack.config.js` file to use the `OfflinePlugin` by @NekR so I can get to and use ASTExplorer.com on the airplane :) Will require additional changes ([for example](kentcdodds/es6-todomvc@FEM/06.2-extract-css...FEM/07.0-offline)). I'm mostly opening this as a PR rather than an issue to discuss it :)
Just a side note about this: kentcdodds/es6-todomvc@FEM/06.2-extract-css...FEM/07.0-offline#diff-fc1b37867580a192c480780240064424R28 You may just remove |
Oh really? What will happen with my call to |
It will work and write a warning into browser's console that you could Here is the content of the runtime by default: When you add offline-plugin into the config, it automagically serves real On Sep 19, 2016 23:12, "Kent C. Dodds" [email protected] wrote: Oh really? What will happen with my call to offlineInstall? — |
Though, I already have reports what that warning is a bit annoying, so I'm On Sep 19, 2016 11:39 PM, "Arthur Stolyar" [email protected] wrote:
|
This is a great idea! Ever since I heard about the plugin I thought about using it for astexplorer. What else specifically do we have to do? |
Well, I heard that there's some integration with Parse.com somewhere. But I think for this first iteration it would be enough to just be able to use the tool, even if it means you can't save what you're working on. So I'm pretty certain that all you'd need to do is add this snippet of code to somewhere in the project (most likely somewhere around the bootstrapping phase of the app): import {install as offlineInstall} from 'offline-plugin/runtime'
offlineInstall() Pretty sure that's it... Maybe further down the road we can disable the "Save" button when you're offline and then add the option to save to localStorage. |
Hi guys, is there any update on this? It looks promising and I was wondering whether I can help :) |
No update. I'm sure a more thorough PR would be appreciated. I know I would love it! |
This commit updates the
webpack.config.js
file to use theOfflinePlugin
by @NekR so I can get to and use ASTExplorer.com on the airplane :)Will require additional changes (for example). I'm mostly opening this as a PR rather than an issue to discuss it :)