Add support for ICU messages and "intl-messageformat-parser" #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
unfortunately it has no support for location info in the node yet (see formatjs/intl-messageformat-parser#16) |
|
Thank you! I'm amazed what "languages" and parsers exist 😉 Will merge this tonight. |
|
Let's hope formatjs/intl-messageformat-parser#17 is merged, then we'll have location information for the nodes too :) |
fkling
added
deploy pending
|
@fkling thanks for merging :) I noticed that the ICU icon is not showing up on the live site though. any ideas what's going on? |
|
It seems to be a caching issue. A hard refresh made the icon appear for me. (caching in general is messed up, I hope this will become less of an issue with #197). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://github.com/yahoo/intl-messageformat-parser