[eslint] Clean up eslint and babel-eslint #227
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The eslint setup in astexplorer is a bit chaotic. I'm not sure if it's worth investing a lot of time to clean this up in the light of #197 (which I will hopefully finish some day 😛 ), so I just did some minimal changes:
babel-eslint
, because that's whateslintUtils
uses.sourceType: 'module'
ineslintUtils
.babel-eslint
parser actually refer tobabel-eslint
and notacorn-to-esprima
.acorn-to-esprima
is deprecated, hide in from the menu.In order to really clean this up,
eslint1
would have to use an older version ofbabel-eslint
that usesacorn-to-esprima
, but I didn't want to spend more time with this.@hzoo , does this look good?
cc @kentcdodds (follow up to #219 )