Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allowed specifying BodyDef properties via constructor #51

Merged
merged 5 commits into from
Mar 29, 2022

Conversation

alestiago
Copy link
Collaborator

Description

Allowed specifying BodyDef properties via the constructor.

The main benefit of this change is that when setting values to default values they get picked up by avoid_redundant_argument_values.

BodyDef()..type = BodyType.static; // Linter doesn't complain.

BodyDef(type: BodyType.static); // Linter complains with avoid_redundant_argument_values

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

#33

@alestiago alestiago changed the title feat: allowed specifying BodyDef properties via constructor feat: allowed specifying BodyDef properties via constructor Mar 27, 2022
@spydon spydon enabled auto-merge (squash) March 29, 2022 09:43
@spydon spydon merged commit aa3f5f7 into flame-engine:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants