-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ObjectAlignment
enum names
#74
Merged
spydon
merged 10 commits into
flame-engine:main
from
ufrshubham:devkage/object-alignment-fix
Nov 3, 2023
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
11d843e
Rename enum values
ufrshubham c8eb735
Create pubspec.yaml
ufrshubham d15fa3c
Revert "Create pubspec.yaml"
ufrshubham 7e58b48
Update enums.dart
ufrshubham 7290844
Add `byName` for `ObjectAlignment`
ufrshubham c2fb2ac
Add `ObjectAlignment` tests
ufrshubham feaccab
Fix lint issues
ufrshubham f43d9e3
Create pubspec.yaml
ufrshubham da4e4e6
Change `byName` to `fromName`
ufrshubham 25147a5
Add trailing comma
ufrshubham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -330,7 +330,7 @@ void main() { | |
image: const TiledImage(), | ||
), | ||
], | ||
) | ||
), | ||
], | ||
); | ||
}); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import 'package:flutter_test/flutter_test.dart'; | ||
import 'package:tiled/tiled.dart'; | ||
|
||
void main() { | ||
group('ObjectAlignment', () { | ||
test('ObjectAlignment.byName', () { | ||
expect( | ||
ObjectAlignment.byName('unspecified'), | ||
ObjectAlignment.unspecified, | ||
); | ||
expect(ObjectAlignment.byName('topleft'), ObjectAlignment.topLeft); | ||
expect(ObjectAlignment.byName('top'), ObjectAlignment.top); | ||
expect(ObjectAlignment.byName('topright'), ObjectAlignment.topRight); | ||
expect(ObjectAlignment.byName('left'), ObjectAlignment.left); | ||
expect(ObjectAlignment.byName('center'), ObjectAlignment.center); | ||
expect(ObjectAlignment.byName('right'), ObjectAlignment.right); | ||
expect(ObjectAlignment.byName('bottomleft'), ObjectAlignment.bottomLeft); | ||
expect(ObjectAlignment.byName('bottom'), ObjectAlignment.bottom); | ||
expect( | ||
ObjectAlignment.byName('bottomright'), | ||
ObjectAlignment.bottomRight, | ||
); | ||
}); | ||
}); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
name: tiled_workspace | ||
|
||
environment: | ||
sdk: ">=3.0.0 <4.0.0" | ||
|
||
dev_dependencies: | ||
melos: ^3.0.0 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed to
fromName