Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adds machine PR support, hides podman behind distro feature flag #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fnerdman
Copy link

Required for compatibility with flashbots/meta-confidential-compute#20

@@ -0,0 +1 @@
include ${@bb.utils.contains('DISTRO_FEATURES', 'podman', 'core-image-tiny-initramfs.inc', '', d)}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would make the automatic build of an image with this layer not feasible and would require the manual modification of the local.conf file prior to building.
I would leave it as before and just rename the name of the file from cvm-image-azure to core-imageg-tiny-initramfs.bbappend instead.

The idea is that one would only need to add the custom-podman-layer if they really need it to be in their final image. There is actually no need to add this layer and not use it. It has only the custom recipe to make podman work within initramfs system

@MoeMahhouk
Copy link
Collaborator

We should make sure before merging such change that the base layer (meta-confidential-compute) is updated updated and functioning with the rest of the layers too (meta-evm, meta-searcher, etc...)

@metachris metachris added the v3 label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants