Move bundle merger #298
Open
Move bundle merger #298
+140
−153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZanCorDX
requested review from
dvush,
ferranbt and
liamaharon
as code owners
Benchmark results for
|
| Date (UTC) | 2024-12-18T21:44:41+00:00 |
| Commit | 24044d643bf8e7101ee187b5f6496e887545f0d2 |
| Base SHA | 8989fca4e065fee013fd3d4aec225e4847cc3028 |
Significant changes
| Benchmark | Mean | Status |
|---|---|---|
| hashing_3000_elements | -4.32% | Performance has improved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
For historical reasons, bundle merging logic (MultiShareBundleMerger) had to be implemented on each algorithm but that's not needed anymore so I removed MultiShareBundleMerger from both algorithms and added it in a single point between simulation and block building.
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test