-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: merge the yocto scripts into yocto manifest #17
base: main
Are you sure you want to change the base?
Conversation
tdx-base.xml
Outdated
<project remote="flashbots" revision="tdx" name="yocto-scripts" path="srcs/yocto-scripts"> | ||
<copyfile dest="setup" src="setup"/> | ||
<copyfile dest="Makefile" src="Makefile"/> | ||
<project remote="flashbots" revision="merge-scripts" name="yocto-manifests" path="srcs/yocto-manifests"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will change to revision main instead later. But for testing purposes, I set it up to this branch to check it out first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the refactor, esp the readmes :)
I'd update this repo's main readme to point to the downstream readmes, and to say a word about where to find what
Separately, config_files
doesn't quite seem to fit. images/
maybe, or definitions
or something with build
@@ -0,0 +1,14 @@ | |||
.PHONY: build gen-measurements | |||
|
|||
build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it make sense to have this in config_files
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had it first for each of the products separately. But I noticed that they all have the same Makefile as a common and use it. So I put it outside instead.
I can create a directory called common and put it in there instead. 🤔
Good Idea, I will update it
I had it first called |
e12df5d
to
81b5c90
Compare
81b5c90
to
cfea317
Compare
This commit integrates the yocto-scripts repository directly into yocto-manifests, consolidating all build configurations under a shared config_files directory.
Key changes:
The consolidation simplifies our repository management while maintaining clear separation between different build profiles. Each profile maintains its own setup script and patches, enabling independent builds