Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screenshots #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

screenshots #112

wants to merge 1 commit into from

Conversation

kompowiec
Copy link

@kompowiec kompowiec commented Dec 1, 2016

add mostly screenshots
source of text: https://nonsa.pl/wiki/Kurnik.pl

@flazz
Copy link
Owner

flazz commented Aug 22, 2017

@kompowiec I like the idea of letting users see before they configure. I'm concerned that screenshots will take up a bunch of space on checkout.

I like the thread you got started on the proposal. What do you think about having a github pages or the wiki host screenshots? is that viable?

@kompowiec
Copy link
Author

hmmi IMO if site can JUST gallery (not will included additional information) it better use special gallery engine eg. coppermine, cpg, Piwigo.

@Swivelgames
Copy link

Swivelgames commented Jun 10, 2019

@flazz No need to include screenshots directly in the repo. A lot of theme repos create an issue and reserve each comment for posting screenshots. You can then copy the URL for those images, and put them in a wiki page. It's a simple, clean way of providing screenshots.

I would say I was just about to close this tab and go look for another repo specifically because there were no screenshots. I'm trying to keep my VIM clean, so I try to avoid adding a plugin just to preview it.

Just a thought! Good luck with the repo! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants