support umd #333
support umd #333
Conversation
src/ng-flow.js
Outdated
|
|
||
| return 'flow'; | ||
| })); |
There was a problem hiding this comment.
300 lines is not enough to warrant splitting this module into multiple files.
| /* for module loading using webpack or similar package bundlers */ | ||
| window.Flow = require('./dist/ng-flow-standalone'); | ||
| module.exports = 'flow'; | ||
| /* backwards compatable with deprecated index.js*/ |
There was a problem hiding this comment.
this file is ignored by commonjs loaders because of the 'main' key in package.json so I log a warning.
| @@ -1,3 +1,7 @@ | |||
| /* for module loading using webpack or similar package bundlers */ | |||
| window.Flow = require('./dist/ng-flow-standalone'); | |||
There was a problem hiding this comment.
mutating window in a commonjs module is not acceptable.
|
@evilaliv3 Can you review this? I haven't used yarn or webpack so I can't test this. But as long as all tests are passing, it is good for me. I think this will be a breaking change for all of our users. We can release it under a major version. |
|
@AidasK ok I'll change it so it's not breaking |
| } | ||
|
|
||
| if (typeof window === 'object') { | ||
| window.Flow = require('@flowjs/flow.js'); |
There was a problem hiding this comment.
mutating window in a commonjs module is not acceptable, but I do it here for require('@flowjs/ng-flow/index') for backwards compatibility reasons.
|
You have also removed ng-flow.js from dist folder, this is bc. I am not against of breaking things. There is nothing wrong in releasing a major version if it is needed. |
oh woops, that's an error. |
No description provided.