-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: re-setup master when master role restarted or recreated and recover dataset #3383
base: master
Are you sure you want to change the base?
feat: re-setup master when master role restarted or recreated and recover dataset #3383
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @SimonCqk. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
804392c
to
cfd7c68
Compare
I think we can do this during entrypoint startup, when master pod recreate or transfer to other node, we can use entrypoint script to recover mount point |
cfd7c68
to
9864cfa
Compare
pkg/ddc/jindo/health_check.go
Outdated
) | ||
|
||
func (e *JindoEngine) CheckRuntimeHealthy() (err error) { | ||
e.Log.V(3).Info("CheckRuntimeHealthy", "runtime name", e.runtimeInfo.GetName()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
V(3) -> V(1). It's because the current log system only supports production or debug level. V(1) indicates debug level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@SimonCqk please fix the source code check, thanks. |
9864cfa
to
df7d99a
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
df7d99a
to
5457202
Compare
done :) |
@@ -0,0 +1,155 @@ | |||
package patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add license header. Thanks.
5457202
to
ed00cdc
Compare
7b16d4e
to
ed00cdc
Compare
Quality Gate passedIssues Measures |
e88ff17
to
bae0ce3
Compare
…over dataset Signed-off-by: SimonCqk <[email protected]>
bae0ce3
to
c0c64b3
Compare
Quality Gate passedIssues Measures |
Ⅰ. Describe what this PR does
fix #3368
Ⅱ. Does this pull request fix one issue?
fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
see /pkg/ctrl/master_test.go
Ⅳ. Describe how to verify it
jindo admin -mount
, check oss mountpoint has been re-mounted or not from stdout.Ⅴ. Special notes for reviews