Bump versions of agp and robolectric, and configure to use SDK 35 #56732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmackall
changed the title
|
cc @utzcoz, just because I've seen you make robolectric related contributions here (no actions needed but any thoughts welcome!) |
|
@gmackall Thanks for your ping. Yeah. I have updated Robolectric version for flutter/engine multiple times. This PR looks great to me. Sorry, but I don't have permission to approve it for you. |
gmackall
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 25, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 25, 2024
…159435) flutter/engine@ce1eb37...fe45a66 2024-11-25 [email protected] Bump versions of agp and robolectric, and configure to use SDK 35 (flutter/engine#56732) 2024-11-25 [email protected] Add missing import for malloc (flutter/engine#56781) 2024-11-25 [email protected] Roll Skia from 7588789d8fc6 to 12c8bd6ac1d9 (1 revision) (flutter/engine#56786) 2024-11-25 [email protected] Roll Skia from 01a3a55f1d54 to 7588789d8fc6 (2 revisions) (flutter/engine#56784) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the version of AGP used in the IDE-support
build.gradle, as well as the robolectric version in both the IDE-supportbuild.gradleand test-runner-build.gradle.This is the current latest robolectric: https://github.com/robolectric/robolectric/releases/tag/robolectric-4.14.1.
Also
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.