-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rename typename U to typename UT to avoid cpprest conflicts #4186
Conversation
FMT_CONSTEXPR auto compare(const Char* s1, const Char* s2, std::size_t n) | ||
-> int { | ||
FMT_CONSTEXPR auto compare(const Char* s1, const Char* s2, | ||
std::size_t n) -> int { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting changes are caused by clang-format so that CI doesn't fail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was using clang-format-18. Using 17 reduces the diff
Thanks for the PR but we shouldn't clutter the code because of poorly written third-party libraries. |
That's fair. However, unfortunately, I noticed that OpenAPI cpprest generator also uses |
That macro is only replacing |
@vitaut @edo9300 The actual Diff is much smaller than in the PR: I was still fixing the clang-format version when the PR was closed. Also, in general using readable typenames instead of single characters is a good idea, however that's another discussion |
Actually, the conflicting code isn't present at all in the current master, so the workaround isn't needed in first place |
Removed in 761d35f |
Fixes #4180
Workaround for microsoft/cpprestsdk#1805