allow context to be mutated in parse methods

doc/CHANGELOG.md

@@ -3,6 +3,7 @@
 
 ##### 1.3.3 (2015-09-05)
 - Polish: add JSON parsing error, disallow empty payload in default serializer for create and update.
+- Fix: allow context to be mutated in `parseUpdate` and `parseCreate`.
 
 
 ##### 1.3.2 (2015-09-03)

lib/dispatch/create.js

@@ -24,16 +24,15 @@ import * as updateHelpers from './update_helpers'
  */
 export default function (context) {
   const { adapter, serializer, recordTypes, transforms } = this
-  let records
-
-  const { type, meta } = context.request
-  const transform = transforms[type]
-  const fields = recordTypes[type]
-  const links = Object.keys(fields)
-    .filter(field => fields[field][linkKey])
-
   const updates = {}
+
   let transaction
+  let records
+  let type
+  let meta
+  let transform
+  let fields
+  let links
 
   return serializer.parseCreate(context)
 
@@ -44,6 +43,11 @@ export default function (context) {
       throw new BadRequestError(
         `There are no valid records in the request.`)
 
+    ; ({ request: { type, meta } } = context)
+    transform = transforms[type]
+    fields = recordTypes[type]
+    links = Object.keys(fields).filter(field => fields[field][linkKey])
+
     // Delete denormalized inverse fields.
     for (let field in fields)
       if (fields[field][denormalizedInverseKey])

lib/dispatch/update.js

@@ -32,16 +32,16 @@ export default function (context) {
   // Keyed by update, valued by hash of linked records.
   const linkedMap = new WeakMap()
 
-  const { request: { type, meta } } = context
-  const fields = recordTypes[type]
-  const transform = transforms[type]
-  const links = Object.keys(fields)
-    .filter(field => fields[field][linkKey])
-
   const relatedUpdates = {}
   const transformedUpdates = []
+
   let transaction
   let updates
+  let type
+  let meta
+  let fields
+  let transform
+  let links
 
   return serializer.parseUpdate(context)
 
@@ -50,6 +50,11 @@ export default function (context) {
 
     validateUpdates(updates)
 
+    ; ({ request: { type, meta } } = context)
+    fields = recordTypes[type]
+    transform = transforms[type]
+    links = Object.keys(fields).filter(field => fields[field][linkKey])
+
     // Delete denormalized inverse fields, can't be updated.
     for (let field in fields)
       if (fields[field][denormalizedInverseKey])

lib/serializer/index.js

@@ -110,7 +110,7 @@ export default class Serializer {
   /**
    * Parse a request payload for creating records. This method should return
    * an array of records as expected by calling the `adapter.create` method.
-   * It should not mutate the context object.
+   * It may also mutate the context object.
    *
    * @param {Object} context
    * @return {Promise|Object[]}
@@ -123,7 +123,7 @@ export default class Serializer {
   /**
    * Parse a request payload for updating records. This method should return
    * an array of updates as expected by calling the `adapter.update` method.
-   * It should not mutate the context object.
+   * It may also mutate the context object.
    *
    * @param {Object} context
    * @return {Promise|Object[]}

package.json

@@ -1,7 +1,7 @@
 {
   "name": "fortune",
   "description": "High-level I/O for web applications.",
-  "version": "1.3.3",
+  "version": "1.3.4",
   "license": "MIT",
   "author": {
     "email": "[email protected]",