Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix pipelines #2573

Merged
merged 2 commits into from
Nov 9, 2024
Merged

chore: fix pipelines #2573

merged 2 commits into from
Nov 9, 2024

Conversation

AsCress
Copy link
Contributor

@AsCress AsCress commented Nov 9, 2024

Adds signing configs to the build.gradle file and fixes other things.

Changes

  • Allows signing of builds.
  • Updates the package name to io.pslab.
  • Other docs added.

Screenshots / Recordings

N/A

Checklist:

  • No hard coding: I have used resources from strings.xml, dimens.xml and colors.xml without hard coding any value.
  • No end of file edits: No modifications done at end of resource files strings.xml, dimens.xml or colors.xml.
  • Code reformatting: I have reformatted code and fixed indentation in every file included in this pull request.
  • No extra space: My code does not contain any extra lines or extra spaces than the ones that are necessary.

Summary by Sourcery

Add signing configurations to the build.gradle file to enable build signing, update the package name to io.pslab, and introduce new documentation including usage guides for the oscilloscope and lux meter, a privacy policy, and commit style guidelines.

Build:

  • Add signing configurations to the build.gradle file to support build signing.

Documentation:

  • Add documentation for using the oscilloscope, lux meter, and a privacy policy.
  • Introduce commit style guidelines for PSLab Android.

Chores:

  • Update the package name to io.pslab.

Copy link

sourcery-ai bot commented Nov 9, 2024

Reviewer's Guide by Sourcery

This PR implements signing configurations for Android builds and adds documentation. The main changes focus on configuring build signing for both local and GitHub environments, along with updating the package name and adding comprehensive documentation for various PSLab features.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Implemented Android app signing configuration
  • Added local properties handling for version code and name
  • Configured signing for both GitHub Actions and local builds
  • Updated release build configuration to use proper signing instead of debug keys
  • Changed package namespace to io.pslab
android/app/build.gradle
Added comprehensive documentation for PSLab features
  • Created documentation for Oscilloscope functionality and usage
  • Added Lux meter documentation with connection diagrams
  • Added privacy policy documentation
  • Created commit style guidelines
docs/Oscilloscope.md
docs/Lux meter.md
docs/privacy_policy.html
docs/commitstyle.md
Added release management configuration
  • Configured release drafter with categorized changes
  • Set up templates for release names and tags
  • Added contributor acknowledgment system
.github/release-drafter.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@AsCress AsCress added the Chore Changes to things that do not go into production label Nov 9, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AsCress - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The prep-key.sh script removes the tar extraction line without replacement - this could break the key preparation process. Please verify if this removal was intentional or if a replacement command is needed.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 1 issue found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

docs/Oscilloscope.md Show resolved Hide resolved
Copy link

github-actions bot commented Nov 9, 2024

@adityastic adityastic merged commit 4a29682 into fossasia:flutter Nov 9, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Changes to things that do not go into production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants