-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix pipelines #2573
chore: fix pipelines #2573
Conversation
Reviewer's Guide by SourceryThis PR implements signing configurations for Android builds and adds documentation. The main changes focus on configuring build signing for both local and GitHub environments, along with updating the package name and adding comprehensive documentation for various PSLab features. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AsCress - I've reviewed your changes - here's some feedback:
Overall Comments:
- The prep-key.sh script removes the tar extraction line without replacement - this could break the key preparation process. Please verify if this removal was intentional or if a replacement command is needed.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 1 issue found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Build successful. APKs to test: https://github.com/fossasia/pslab-android/actions/runs/11755541248/artifacts/2166500217 |
Adds signing configs to the
build.gradle
file and fixes other things.Changes
io.pslab
.Screenshots / Recordings
N/A
Checklist:
strings.xml
,dimens.xml
andcolors.xml
without hard coding any value.strings.xml
,dimens.xml
orcolors.xml
.Summary by Sourcery
Add signing configurations to the build.gradle file to enable build signing, update the package name to io.pslab, and introduce new documentation including usage guides for the oscilloscope and lux meter, a privacy policy, and commit style guidelines.
Build:
Documentation:
Chores: