Merge pull request #157 from shariquerik/keyboard-integration-fix

frappe · Jun 8, 2022 · b442863 · b442863
2 parents fea45f4 + d6a6c16
commit b442863
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/cellmanager.js b/src/cellmanager.js
@@ -520,9 +520,12 @@ export default class CellManager {
                 }
 
                 promise = valuePromise.then((value) => {
-                    const done = editor.setValue(value, rowIndex, col);
                     const oldValue = this.getCell(colIndex, rowIndex).content;
 
+                    if (oldValue === value) return false;
+
+                    const done = editor.setValue(value, rowIndex, col);
+
                     // update cell immediately
                     this.updateCell(colIndex, rowIndex, value);
                     $cell.focus();
@@ -643,7 +646,7 @@ export default class CellManager {
     }
 
     focusCellInDirection(direction) {
-        if (!this.$focusedCell) {
+        if (!this.$focusedCell || (this.$editingCell && ['left', 'right', 'up', 'down'].includes(direction))) {
             return false;
         } else if (this.$editingCell && ['tab', 'shift+tab'].includes(direction)) {
             this.deactivateEditing();