Merge pull request #98 from prssanna/sort-fix

fix: 🐛 set content of empty cell to empty string for sorting
frappe · Mar 16, 2020 · c263ab4 · c263ab4
2 parents 3475f6c + 18964c0
commit c263ab4
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/datamanager.js b/src/datamanager.js
@@ -280,8 +280,11 @@ export default class DataManager {
         this.rowViewOrder.sort((a, b) => {
             const aIndex = a;
             const bIndex = b;
-            const aContent = this.getCell(colIndex, a).content;
-            const bContent = this.getCell(colIndex, b).content;
+
+            let aContent = this.getCell(colIndex, a).content;
+            let bContent = this.getCell(colIndex, b).content;
+            aContent = aContent == null ? '' : aContent;
+            bContent = bContent == null ? '' : bContent;
 
             if (sortOrder === 'none') {
                 return aIndex - bIndex;