-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix header and footer in rtl body direction #56
base: master
Are you sure you want to change the base?
Conversation
i test it locally it works fine with me .. |
@netchampfaris what do you think? |
@ahmed-madi there is issue when change the col size it do the ltr not rtl adjustment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when change the size of columns it goes to LTR not RTL
Please give scenario with steps to reproduce |
@ahmed-madi i try to make some columns width changes so in RTL the same direction as LTR in width addition .. it should go to right not left |
@ahmadRagheb Could You fix the Conflicting files? |
Header and footer don't scroll when the body is in rtl direction, and this is because of the different value of scrollLeft in different browsers when the direction is rtl, also - sign should be inside the Template string like this ${-scrollLeft} to be calculated properly in case of rtl body direction because Firefox calculates the value of the scrollLeft in negative when the direction is rtl so translateX need a positive value to move as expected. this pull request fix these issues.
Thank you