Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header and footer in rtl body direction #56

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ahmed-madi
Copy link

Header and footer don't scroll when the body is in rtl direction, and this is because of the different value of scrollLeft in different browsers when the direction is rtl, also - sign should be inside the Template string like this ${-scrollLeft} to be calculated properly in case of rtl body direction because Firefox calculates the value of the scrollLeft in negative when the direction is rtl so translateX need a positive value to move as expected. this pull request fix these issues.

Thank you

@ahmadRagheb
Copy link

i test it locally it works fine with me ..
but when i use it inside frappe bench and goo to node module and build it doesn't work ?

@ahmadRagheb
Copy link

@netchampfaris what do you think?

@ahmadRagheb
Copy link

@ahmed-madi there is issue when change the col size it do the ltr not rtl adjustment

Copy link

@ahmadRagheb ahmadRagheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when change the size of columns it goes to LTR not RTL

@ahmed-madi
Copy link
Author

when change the size of columns it goes to LTR not RTL

Please give scenario with steps to reproduce

@ahmadRagheb
Copy link

@ahmed-madi i try to make some columns width changes so in RTL the same direction as LTR in width addition .. it should go to right not left

@mhbu50
Copy link

mhbu50 commented May 11, 2019

@ahmadRagheb Could You fix the Conflicting files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants