Configurable audio ports support #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
abique
requested changes
Sep 16, 2024
| ///////////////////////////// | ||
| template<MisbehaviourHandler h, CheckingLevel l> | ||
| bool PluginProxy<h, l>::canUseConfigurableAudioPorts() const noexcept { | ||
| if(!_pluginConfigurableAudioPorts) { |
There was a problem hiding this comment.
You have to check that the methods aren't null pointers as well.
|
|
||
| template<MisbehaviourHandler h, CheckingLevel l> | ||
| bool PluginProxy<h, l>::configurableAudioPortsCanApplyConfiguration(clap_audio_port_configuration_request *requests, uint32_t requests_count) const noexcept { | ||
| if(!_pluginConfigurableAudioPorts) return false; |
There was a problem hiding this comment.
You should call canUseConfigurableAudioPorts() here.
|
|
||
| template<MisbehaviourHandler h, CheckingLevel l> | ||
| bool PluginProxy<h, l>::configurableAudioPortsApplyConfiguration(clap_audio_port_configuration_request *requests, uint32_t requests_count) const noexcept { | ||
| if(!_pluginConfigurableAudioPorts) return false; |
There was a problem hiding this comment.
You should call canUseConfigurableAudioPorts() here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was discussing this with Timo in the discord, and figured I'd try and add the configurable audio ports extension stuff into the helpers - I'm a bit shaky on the proxy stuff, so any sanity checking here would be super appreciated, obviously let me know if I've missed anything super obvious!