Defensive guard of CFTimerCreate #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
on macOS we do a cf timer create / destroy in attach/detatch but we don't guard for success. the vst3 validator has this fail so we will dump core on detach in some cases. Guard. And clean up an unused data structure while at it
baconpaul
force-pushed
the
macos-timer
branch
from
97cb588 to
2a0a12c
Compare
defiantnerd
pushed a commit
that referenced
this pull request
Sep 9, 2023
on macOS we do a cf timer create / destroy in attach/detatch but we don't guard for success. the vst3 validator has this fail so we will dump core on detach in some cases. Guard. And clean up an unused data structure while at it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on macOS we do a cf timer create / destroy in attach/detatch but we don't guard for success. the vst3 validator has this fail so we will dump core on detach in some cases. Guard.