param-origin extension #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add .DS_Store to .gitignore (MacOS specific) Fixes: free-audio#390
Summarizing the conversation in discussion free-audio#414, this PR adds a more complete description of when the realtime constraint must be met, by which party, and how it interacts with the thread safe tag.
- allow plugin_latency->get to be called during plugin->activate - require host_latency->changed to be called during plugin->activate
- the plugin interfaces have been separated into 2 independent ones - the plugin interfaces are optional - simplification of the design
…-audio#422) * Add a description of the expectation of request_callback timing Without making a requirement, indicate the intent of the timing. * Add an apostrophe * Add host can starve feedback from alex * more review feedback * notjusthosts
|
Yeah, this is useful addition to the model. I considered having some flags for symbolic values:
I'm happy with the PR, thanks. |
|
I commented that it seems this and the step resolution one could be combined into a single 'param-extended-info' with key/value which retained abi as we add keys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see in-code documentation. If something is not specified enough, please ask/propose changes of course 👍