Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rc.initdiskless, fix error handling of remount_optional #1497

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update rc.initdiskless, fix error handling of remount_optional #1497

wants to merge 1 commit into from

Commits on Oct 27, 2024

  1. Update rc.initdiskless, fix error handling of remount_optional 

    chkerr() ignores the exit code of a preceding mount command in case a file ```remount_optional``` exists.
The check is performed and a subshell is launched to log the informational message and return.
The return is executed in the context of the subshell, not the context of the chkerr() function, hence is a NOP.
The remount_optional check is hence ineffective.

Change the code to if/then/fi, so the return is evaluated in the context of the  chkerr function, to make the check effective.
    @kevemueller
    kevemueller authored Oct 27, 2024
    Configuration menu
    Copy the full SHA
    5596269 View commit details
    Browse the repository at this point in the history