-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Management commands to clone opinions and dockets in local environment #2436
Conversation
for more information, see https://pre-commit.ci
I haven't looked at the code yet, but any reason you can't put these into one management command? Just notionally: manage.py clone_from_cl --obj-type search.Opinion --id 123 manage.py clone_from_cl --object-type search.Docket --id 123 I guess it'd be nice if it used object types similar to those in other management commands. I think the cl_update_search command has some examples (they might even be in an |
for more information, see https://pre-commit.ci
- Allow to clone person and court
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, LOTS of comments here, but I think this will be a good one to drive home a few good practices. Let me know what you think, and thanks for putting together this useful tool.
Co-authored-by: Mike Lissner <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Mike Lissner <[email protected]>
for more information, see https://pre-commit.ci
… object type as argument, move code out of transaction
for more information, see https://pre-commit.ci
the changes you requested are ready @mlissner |
There are still some unresolved comments. Can you please take another look and get those resolved? |
Yes, I think there were many comments and that's why some were hidden and that's why I didn't see them🤦, i'm on it 👍 |
All changes should be ready @mlissner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is about 1,000× better, thank you @quevon24! I think it's good now, but I made a few more comments that I think will make it great.
Thanks for sticking with this one. It's small, but it's covering a lot of ground in terms of our norms and standards around here that I think will help with many of your future PRs.
I appreciate all your comments, I know this will help me improve my skills and code better 😊 |
…mmand Use reverse for endpoints, code formatting, new helper function
for more information, see https://pre-commit.ci
Almost all requested changes are complete @mlissner I only left you a comment on one of the requested changes |
Two of our CI tools broke, so I fixed them in another branch that I just merged and then rebased this on. This is set to auto-merge as of now. I'll check back and make sure it gets into the system. Thank you for taking the initiative to write and land these tools. |
This are two useful management commands for development purposes, these commands allows you to clone opinion clusters or only dockets in case of need.
For example:
These commands only work if you have the env variable DEVELOPMENT set to True.