Update LICENSE #38
funilrysmain.yml
on: push
Annotations
42 warnings
|
Check Package
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Check Package
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Check Package:
src/utils.rs#L145
function `extract_netloc` is never used
|
|
Check Package
`tivilsta` (bin "tivilsta") generated 1 warning
|
|
Check Package
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Check Package
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Check Package
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Check Package
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
single-character string constant used as pattern:
src/utils.rs#L162
warning: single-character string constant used as pattern
--> src/utils.rs:162:31
|
162 | result = result.split("/").next().unwrap()
| ^^^ help: consider using a `char`: `'/'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
|
|
single-character string constant used as pattern:
src/utils.rs#L161
warning: single-character string constant used as pattern
--> src/utils.rs:161:24
|
161 | if result.contains("/") {
| ^^^ help: consider using a `char`: `'/'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
= note: `#[warn(clippy::single_char_pattern)]` on by default
|
|
unneeded `return` statement:
src/utils.rs#L110
warning: unneeded `return` statement
--> src/utils.rs:110:5
|
110 | return (fetch_file(user_input, &tmp_path).unwrap_or(tmp_path), true);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
110 - return (fetch_file(user_input, &tmp_path).unwrap_or(tmp_path), true);
110 + (fetch_file(user_input, &tmp_path).unwrap_or(tmp_path), true)
|
|
|
function `extract_netloc` is never used:
src/utils.rs#L145
warning: function `extract_netloc` is never used
--> src/utils.rs:145:8
|
145 | pub fn extract_netloc(data: &String) -> String {
| ^^^^^^^^^^^^^^
|
= note: `#[warn(dead_code)]` on by default
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/lib.rs#L611
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/lib.rs:611:43
|
611 | let fline = utils::extract_netloc(&line);
| ^^^^^ help: change this to: `line`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
|
|
unneeded late initialization:
src/lib.rs#L420
warning: unneeded late initialization
--> src/lib.rs:420:9
|
420 | let record: String;
| ^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
help: declare `record` here
|
422 | let record: String = if self.settings.handle_complement && line.starts_with("www.") {
| ++++++++++++++++++++
help: remove the assignments from the branches
|
423 ~ line.replacen("www.", "", 1).trim().to_string()
424 | } else {
425 ~ line.to_string()
|
help: add a semicolon after the `if` expression
|
426 | };
| +
|
|
writing `&String` instead of `&str` involves a new object where a slice will do:
src/lib.rs#L403
warning: writing `&String` instead of `&str` involves a new object where a slice will do
--> src/lib.rs:403:39
|
403 | fn unparse_regex(&mut self, line: &String) -> bool {
| ^^^^^^^ help: change this to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
|
|
writing `&String` instead of `&str` involves a new object where a slice will do:
src/lib.rs#L387
warning: writing `&String` instead of `&str` involves a new object where a slice will do
--> src/lib.rs:387:37
|
387 | fn parse_regex(&mut self, line: &String) -> bool {
| ^^^^^^^ help: change this to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
|
|
writing `&String` instead of `&str` involves a new object where a slice will do:
src/lib.rs#L357
warning: writing `&String` instead of `&str` involves a new object where a slice will do
--> src/lib.rs:357:46
|
357 | fn unparse_root_zone_db(&mut self, line: &String) -> bool {
| ^^^^^^^ help: change this to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
|
|
writing `&String` instead of `&str` involves a new object where a slice will do:
src/lib.rs#L327
warning: writing `&String` instead of `&str` involves a new object where a slice will do
--> src/lib.rs:327:44
|
327 | fn parse_root_zone_db(&mut self, line: &String) -> bool {
| ^^^^^^^ help: change this to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
|
|
`to_string` applied to a type that implements `Display` in `format!` args:
src/lib.rs#L315
warning: `to_string` applied to a type that implements `Display` in `format!` args
--> src/lib.rs:315:57
|
315 | self.pull_strict(&format!("www.{}", record[1..].to_string()));
| ^^^^^^^^^^^^^^^^^^^^^^^ help: use this: `&record[1..]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
|
|
stripping a prefix manually:
src/lib.rs#L315
warning: stripping a prefix manually
--> src/lib.rs:315:57
|
315 | self.pull_strict(&format!("www.{}", record[1..].to_string()));
| ^^^^^^^^^^^
|
note: the prefix was tested here
--> src/lib.rs:312:9
|
312 | if record.starts_with('.') {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
help: try using the `strip_prefix` method
|
312 ~ if let Some(<stripped>) = record.strip_prefix('.') {
313 | if record.matches('.').count() > 1 {
314 | if self.settings.handle_complement {
315 ~ self.pull_strict(&format!("www.{}", <stripped>.to_string()));
316 | }
317 ~ self.pull_strict(&<stripped>.to_string());
|
|
|
writing `&String` instead of `&str` involves a new object where a slice will do:
src/lib.rs#L301
warning: writing `&String` instead of `&str` involves a new object where a slice will do
--> src/lib.rs:301:37
|
301 | fn unparse_all(&mut self, line: &String) -> bool {
| ^^^^^^^ help: change this to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
|
|
`to_string` applied to a type that implements `Display` in `format!` args:
src/lib.rs#L289
warning: `to_string` applied to a type that implements `Display` in `format!` args
--> src/lib.rs:289:57
|
289 | self.push_strict(&format!("www.{}", record[1..].to_string()));
| ^^^^^^^^^^^^^^^^^^^^^^^ help: use this: `&record[1..]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
= note: `#[warn(clippy::to_string_in_format_args)]` on by default
|
|
stripping a prefix manually:
src/lib.rs#L289
warning: stripping a prefix manually
--> src/lib.rs:289:57
|
289 | self.push_strict(&format!("www.{}", record[1..].to_string()));
| ^^^^^^^^^^^
|
note: the prefix was tested here
--> src/lib.rs:286:9
|
286 | if record.starts_with('.') {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
help: try using the `strip_prefix` method
|
286 ~ if let Some(<stripped>) = record.strip_prefix('.') {
287 | if record.matches('.').count() > 1 {
288 | if self.settings.handle_complement {
289 ~ self.push_strict(&format!("www.{}", <stripped>.to_string()));
290 | }
291 ~ self.push_strict(&<stripped>.to_string());
|
|
|
writing `&String` instead of `&str` involves a new object where a slice will do:
src/lib.rs#L275
warning: writing `&String` instead of `&str` involves a new object where a slice will do
--> src/lib.rs:275:35
|
275 | fn parse_all(&mut self, line: &String) -> bool {
| ^^^^^^^ help: change this to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
|
|
writing `&String` instead of `&str` involves a new object where a slice will do:
src/lib.rs#L152
warning: writing `&String` instead of `&str` involves a new object where a slice will do
--> src/lib.rs:152:39
|
152 | fn search_keys(&mut self, record: &String) -> (String, String) {
| ^^^^^^^ help: change this to: `&str`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
= note: `#[warn(clippy::ptr_arg)]` on by default
|
|
stripping a prefix manually:
src/lib.rs#L132
warning: stripping a prefix manually
--> src/lib.rs:132:22
|
132 | result = element[4..].to_string()
| ^^^^^^^^^^^^
|
note: the prefix was tested here
--> src/lib.rs:131:9
|
131 | if element.starts_with("www.") {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip
= note: `#[warn(clippy::manual_strip)]` on by default
help: try using the `strip_prefix` method
|
131 ~ if let Some(<stripped>) = element.strip_prefix("www.") {
132 ~ result = <stripped>.to_string()
|
|
|
unneeded late initialization:
src/lib.rs#L129
warning: unneeded late initialization
--> src/lib.rs:129:9
|
129 | let result;
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init
= note: `#[warn(clippy::needless_late_init)]` on by default
help: declare `result` here
|
131 | let result = if element.starts_with("www.") {
| ++++++++++++
help: remove the assignments from the branches
|
132 ~ element[4..].to_string()
133 | } else {
134 ~ element.to_string()
|
help: add a semicolon after the `if` expression
|
135 | };
| +
|
|
single-character string constant used as pattern:
src/utils.rs#L162
warning: single-character string constant used as pattern
--> src/utils.rs:162:31
|
162 | result = result.split("/").next().unwrap()
| ^^^ help: consider using a `char`: `'/'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
|
|
single-character string constant used as pattern:
src/utils.rs#L161
warning: single-character string constant used as pattern
--> src/utils.rs:161:24
|
161 | if result.contains("/") {
| ^^^ help: consider using a `char`: `'/'`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
= note: `#[warn(clippy::single_char_pattern)]` on by default
|
|
unneeded `return` statement:
src/utils.rs#L110
warning: unneeded `return` statement
--> src/utils.rs:110:5
|
110 | return (fetch_file(user_input, &tmp_path).unwrap_or(tmp_path), true);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
|
110 - return (fetch_file(user_input, &tmp_path).unwrap_or(tmp_path), true);
110 + (fetch_file(user_input, &tmp_path).unwrap_or(tmp_path), true)
|
|
|
Lint Package
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Lint Package
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Lint Package
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Lint Package
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Lint Package
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Lint Package
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test Package
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Test Package
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test Package
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test Package
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test Package
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test Package
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|