Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pipeline #551

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

update pipeline #551

wants to merge 2 commits into from

Conversation

chenrui333
Copy link
Contributor

@chenrui333 chenrui333 commented Jan 19, 2024 •
edited
Loading

  • ci: add java21 support
  • deploy: use java17 (same as dockerfile)

relates to #550

@github-actions github-actions bot added the ci-cd CI/CD-related (GitHub Actions) label Jan 19, 2024
fwcd
fwcd reviewed Jan 24, 2024
View reviewed changes
.github/workflows/deploy.yml
@@ -14,7 +14,7 @@ jobs:
uses: actions/setup-java@v3
with:
distribution: 'temurin'
java-version: '11'
Copy link
Owner

@fwcd fwcd Jan 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, I would like to keep the deploy on JDK 11 for as long as possible to make sure that the binaries stay compatible with JDK 11.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, is this some requirement from kotlin?

@chenrui333 chenrui333 mentioned this pull request Jan 26, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwcd fwcd fwcd left review comments

Assignees
No one assigned
Labels
ci-cd CI/CD-related (GitHub Actions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenrui333 @fwcd