Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a componentReady event #99

Merged
merged 7 commits into from
Feb 1, 2024
Merged

Add a componentReady event #99

merged 7 commits into from
Feb 1, 2024

Conversation

brinkofblink
Copy link
Contributor

Hi @fymmot,

I wonder if you would be happy to merge a tiny new feature?
It's a custom event which fires on componentDidLoad.

It's useful for when you need to check for things like startDate from external js.

PS - You have already merged the other commits mentioned in this PR - I'm honestly not sure why they're listed here shrugs.

When this is a child element of a form, adding type=“button” will prevent the form beinbvg submitted on click.
- Add a disabled date message to inclusiveDatesLabels
- check if date is disabled in handleChange()
- Show a message if it is disabled
Useful for when you need to check for things like startDate from outside the web component
Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
inclusive-dates ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 11:25am

@fymmot fymmot merged commit 2ed8a97 into fymmot:main Feb 1, 2024
2 checks passed
@fymmot
Copy link
Owner

fymmot commented Feb 1, 2024

Thank you @brinkofblink !

If you want, I could make you a co-maintainer of this project?

Sad to say but I haven't had as much time as I would have liked to spend on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants