Add command to scan for new translation

[sdassow]

Description:

Adds a translate command that scans for new translation and updates the translations file.

No new external modules are imported.
The resulting size increase for the fyne command binary is 830kb on this version of macOS:

$ ls -al fyne*
-rwxr-xr-x  1 simon  staff  17764240 Nov  2 13:48 fyne
-rwxr-xr-x  1 simon  staff  16913632 Nov  2 13:47 fyne.develop

Checklist:

• Tests included.
• Lint and formatter run with no errors.
• Tests all pass.

Where applicable:

• Public APIs match existing style and have Since: line.
• No breaking changes (new command).
• Check for binary size increases when importing new modules.

[andydotxyz]

Can you please factor code out of the 'Translate' method? 120 lines seems very long for something that could be broken down. That would also facilitate adding a test :).

Lastly do note to check the boxes on your PR template so we can see where it's at

[coveralls]

coverage: 59.983% (+0.02%) from 59.961%
when pulling edf95e5 on sdassow:add-translate-command
into de361f6 on fyne-io:develop.

[andydotxyz]

Just FYI we have now update the CI version requirements so you'll need to rebase on latest develop to get a full build to pass

[andydotxyz]

Found a few logic glitches which I commented inline.

However the biggest comment would be that we avoid code comments unless really required. More often than not an inline comment shows a lack of clarity in the code.

[andydotxyz]

This looks pretty epic. Just continuing a comment from before.

[andydotxyz]

Those Windows errors seem to indicate you haven't closed a file before trying to remove it.

[sdassow]

Those Windows errors seem to indicate you haven't closed a file before trying to remove it.

Sort of like that. The problem was doing chdir into the temp directory in the test as it prevents removal.

[sdassow]

This looks pretty epic. Just continuing a comment from before.

Did I miss the comment or was it addressed? I'm not sure at the moment.

[andydotxyz]

This looks pretty epic. Just continuing a comment from before.

Did I miss the comment or was it addressed? I'm not sure at the moment.

Unfortunately force-pushing after a review often kills comments - GitHub has an habit of losing them so we ask folk not to force after first review. It all looks good though thanks - I will run some tests but pretty excited to see this added!

[andydotxyz]

Thanks so much, I tried this out but I think it doesn't create the folder if it doesn't exist.

[sdassow-add-translate-command] ><> go run ../fyne translate *.go   
open translations/en.json-182321854: no such file or directory
exit status 1

My first attempt was to pass a directory but it didn't work - should it? :)

Last comment. Our translations were 2 spaces, weblate default is 4 spaces and this is tabs.
It would be good to get this and our internal files consistent at least - so we should agree on the approach.

[sdassow]

Thanks so much, I tried this out but I think it doesn't create the folder if it doesn't exist.

[sdassow-add-translate-command] ><> go run ../fyne translate *.go   
open translations/en.json-182321854: no such file or directory
exit status 1

That's not a nice experience. Changed it.
The first argument is now mandatory instead and specifies the file to use to avoid any confusion.
When the first argument is missing it shows this:

Missing argument: translationsFile
usage: fyne translate [command options] translationsFile [source ...]

My first attempt was to pass a directory but it didn't work - should it? :)

Absolutely, and it does now :)

Last comment. Our translations were 2 spaces, weblate default is 4 spaces and this is tabs. It would be good to get this and our internal files consistent at least - so we should agree on the approach.

Since we use weblate I've changed it to 4 spaces.

[sdassow]

Additionally it's now checking the first argument:

$ ./fyne translate
Missing argument: translationsFile
usage: fyne translate [command options] translationsFile [source ...]
$ ./fyne translate *.go
Need .json extension for translationsFile
usage: fyne translate [command options] translationsFile [source ...]
$

[sdassow]

Additionally it's now checking the first argument:

$ ./fyne translate
Missing argument: translationsFile
usage: fyne translate [command options] translationsFile [source ...]
$ ./fyne translate *.go
Need .json extension for translationsFile
usage: fyne translate [command options] translationsFile [source ...]
$

Why make the translations file a mandatory argument you ask?

• works regardless of the current directory or sub-directories
• makes no assumptions about the default language, leaving the decision to the developer

[andydotxyz]

Apologies for the delay. I have tried this latest version but can't seem to figure it out.
In the Fyne repo I removed one of the English translation lines and ran the command:

go run ./cmd/fyne translate --dry-run lang/translations/base.en.json .

But I see no output at all - any idea what I am doing wrong?

When I ran it without --dry-run it re-added the translation as expected.

[sdassow]

go run ./cmd/fyne translate --dry-run lang/translations/base.en.json .

But I see no output at all - any idea what I am doing wrong?

You're doing it right. I think --dry-run is useless now, and definitely pointless without --verbose.
When the translation file name was implicit it seemed useful, but with the latest changes it doesn't.
I'm going to remove it - if someone wants to see changes to existing files they can use a different filename and check the delta. Or use version control. Or pipe to STDOUT and use diff(1).