Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix VtkViewerNew for VTK 9.4.0 #218

Merged
merged 3 commits into from
Dec 7, 2024
Merged

fix VtkViewerNew for VTK 9.4.0 #218

merged 3 commits into from
Dec 7, 2024

Conversation

ManuelHu
Copy link
Contributor

@ManuelHu ManuelHu commented Dec 7, 2024

this should fix:

FAILED tests/fluka/test_Fluka.py::test_fluka_vis - TypeError: unhashable type: 'PolyData'
FAILED tests/visualisation/test_Convert.py::test_vtkPolyDataToNumpy - TypeError: unhashable type: 'PolyData'
FAILED tests/visualisation/test_Visualisation.py::test_VtkViewerNewAppend - TypeError: unhashable type: 'PolyData'
FAILED tests/visualisation/test_Visualisation.py::test_VtkViewerColouredNewAppend - TypeError: unhashable type: 'PolyData'
FAILED tests/visualisation/test_Visualisation.py::test_VtkViewerColouredMaterialNewAppend - TypeError: unhashable type: 'PolyData'

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.11%. Comparing base (cf097c1) to head (e0ebd94).

Files with missing lines Patch % Lines
src/pyg4ometry/visualisation/VtkViewerNew.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   74.12%   74.11%   -0.01%     
==========================================
  Files         157      157              
  Lines       22735    22735              
==========================================
- Hits        16853    16851       -2     
- Misses       5882     5884       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ManuelHu
Copy link
Contributor Author

ManuelHu commented Dec 7, 2024

also limits sphinx-autoapi version to < 3.4.0 (see readthedocs/sphinx-autoapi#504)

@gipert gipert merged commit a973484 into g4edge:main Dec 7, 2024
2 checks passed
@ManuelHu ManuelHu deleted the patch-3 branch December 7, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants