Allow use of headless hostname #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelini
force-pushed
the
allow_use_of_headless_hostname
branch
2 times, most recently
from
54eccb7 to
2317280
Compare
angelini
force-pushed
the
allow_use_of_headless_hostname
branch
from
2317280 to
2b15877
Compare
|
I have 🎩 this from evil-ssh pod and I was able to connect to DL using the headless hostname and omitting it. |
angelini
force-pushed
the
allow_use_of_headless_hostname
branch
2 times, most recently
from
dde4aa6 to
531b08a
Compare
thegedge
approved these changes
Dec 5, 2023
pkg/client/client.go
Outdated
| @@ -55,7 +55,8 @@ func NewClientConn(conn *grpc.ClientConn) *Client { | |||
| } | |||
|
|
|||
| type options struct { | |||
| token string | |||
| headlessAdress string | |||
angelini
force-pushed
the
allow_use_of_headless_hostname
branch
from
531b08a to
3d56ef7
Compare
angelini
force-pushed
the
allow_use_of_headless_hostname
branch
from
3d56ef7 to
6445881
Compare
angelini
force-pushed
the
allow_use_of_headless_hostname
branch
from
6445881 to
959a047
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One issue with using
dateilager.gadget-services.netto resolve a DL instance is that the K8S service will resolve this to a single instance IP.If for wtv reason you fail to connect to that IP, for example during a DL deployment, it cannot recover by trying another instance because it has already been resolved to that fixed IP.
If instead we use a headless service, we can learn about all instances and then retry among different ones.
We already make use of this for our GRPC JS client, this just adds it to the binary client.