Staged Update #79
Open
Staged Update #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelini
force-pushed
the
staged_update
branch
8 times, most recently
from
485ccfb to
1bd935c
Compare
angelini
requested review from
scott-rc,
airhorns and
MikePresman
and removed request for
airhorns
|
/cc @airhorns |
MikePresman
reviewed
Mar 20, 2024
| if isStaged { | ||
| batch.Queue(` | ||
| INSERT INTO dl.staged_objects (project, start_version, stop_version, path, hash, mode, size, packed) | ||
| VALUES ($1, NULL, $2, $3, NULL, NULL, NULL, NULL) |
There was a problem hiding this comment.
is setting start_version as NULL a pattern used to distinguish the fact that its staged? I see this here and in DeleteObject
scott-rc
approved these changes
Mar 20, 2024
|
@scott-rc @MikePresman we've decided to pause this feature as Kyle is working on an alternative that would not require this. You can avoid spending time reviewing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to stage an update and then commit it at a later point in time.
You call the existing
Updateendpoint with a new flag, this should be backwards compatible because the flag will default tofalse, and then instead of writing toobjectsthe rows will be written todl.staged_objects.You can then follow up with a call to a new RPC endpoint
Commitwhich will actually make that version the current version for your project.The main, fairly conservative, decision that I took was to only allow you to commit a version if no updates have happened since you staged it.
This means if you:
I think this makes it much easier to reason about, but it could be problematic in practice where multiple systems are trying to update a project at once.
Remaining TODOs:
Add testsEnsure that the GC can't delete objects that are currently staged