db(add columns): created_at #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikePresman
force-pushed
the
add/datetime-to-objects
branch
from
6405e0b to
adabbd1
Compare
MikePresman
changed the title
angelini
reviewed
Jun 4, 2024
| @@ -0,0 +1 @@ | |||
| ALTER TABLE dl.objects ADD COLUMN created_at TIMESTAMP DEFAULT CURRENT_TIMESTAMP NOT NULL; | |||
There was a problem hiding this comment.
I think defaulting to current timestamp is cool, we wouldn't need to add any code changes and would get created_at for free.
The only worry here is what do we do for existing rows, I kind of feel like they should be null instead of some fixed date when we rolled this out.
Can you try testing the following:
- Create rows without this patch
- Run this migration (without the
NOT NULLpart)
Do the existing rows get the date of the migration as their value or null? I suspect they'll get the date of the migration.
We might need to run a first migration with default null and then a second migration with default current_timestamp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added these columns since they are extremely helpful for tracking when a version was created