This repository has been archived by the owner on Nov 11, 2024. It is now read-only.
Add REST API endpoints for secrets #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eamonn Mansour <[email protected]>
Signed-off-by: Eamonn Mansour <[email protected]>
Signed-off-by: Eamonn Mansour <[email protected]>
Signed-off-by: Eamonn Mansour <[email protected]>
…d updating existing secrets Signed-off-by: Eamonn Mansour <[email protected]>
Signed-off-by: Eamonn Mansour <[email protected]>
This was referenced Oct 28, 2024
This was referenced Oct 28, 2024
techcobweb
reviewed
Oct 28, 2024
....framework.api.common/src/main/java/dev/galasa/framework/api/common/ServletErrorMessage.java
Outdated
Show resolved
Hide resolved
techcobweb
reviewed
Oct 28, 2024
galasa-parent/dev.galasa.framework.api.openapi/src/main/resources/openapi.yaml
Show resolved
Hide resolved
techcobweb
reviewed
Oct 28, 2024
...crets/src/main/java/dev/galasa/framework/api/secrets/internal/routes/SecretDetailsRoute.java
Show resolved
Hide resolved
|
I think we said we needed a description for each credential ? I don't see that being stored away at all. I think that's necessary to explain what each secret is used for, where the source for it comes from...etc. Can we return a last updated time in the secret also ? or is that a separate story ? Much extra work to do or not ? |
Signed-off-by: Eamonn Mansour <[email protected]>
techcobweb
approved these changes
Oct 28, 2024
Signed-off-by: Eamonn Mansour <[email protected]>
Signed-off-by: Eamonn Mansour <[email protected]>
eamansour
force-pushed
the
iss1467-secrets-api
branch
from
36bf362 to
3447130
Compare
Signed-off-by: Eamonn Mansour <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
See galasa-dev/projectmanagement#1467
Changes
GET /secretsto get all secrets in the credentials storeGET /secrets/{secretName}to get an individual secretPOST /secretsto create a new secretDELETE /secrets/{secretName}to delete an existing secretPUT /secrets/{secretName}to update an existing secret, or create it if it does not exist