Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker manager template tests #365

Open
wants to merge 24 commits into
base: next
Choose a base branch
from
Open

docker manager template tests #365

wants to merge 24 commits into from

Conversation

CaroMac
Copy link
Contributor

@CaroMac CaroMac commented Mar 13, 2022

No description provided.

@CaroMac CaroMac self-assigned this Mar 13, 2022
@CaroMac CaroMac requested a review from hobbit1983 June 7, 2022 19:39
hobbit1983
hobbit1983 requested changes Aug 17, 2022
View reviewed changes
Copy link
Member

@hobbit1983 hobbit1983 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all the information needed is in here - we just need to stick it in a different order. How about:

  • Overview
  • Configuring
  • Adding a dependency to this manager
  • Configuring the CPS for this manager
  • Provided annotations
  • Code Snippets and examples

src/markdown-pages/docs/managers/docker-manager2.md Outdated Show resolved Hide resolved
src/markdown-pages/docs/managers/docker-manager2.md Outdated Show resolved Hide resolved
src/markdown-pages/docs/managers/docker-manager2.md Outdated Show resolved Hide resolved
@CaroMac CaroMac requested a review from hobbit1983 August 25, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hobbit1983 hobbit1983 Awaiting requested review from hobbit1983

Requested changes must be addressed to merge this pull request.

Assignees

@CaroMac CaroMac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CaroMac @hobbit1983