Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs on rotating encryption keys and managing secrets #840

Merged
merged 6 commits into from
Nov 29, 2024
Merged

Add docs on rotating encryption keys and managing secrets #840

merged 6 commits into from
Nov 29, 2024

Conversation

eamansour
Copy link
Member

@eamansour eamansour commented Nov 1, 2024 •
edited
Loading

Why?

See galasa-dev/projectmanagement#1467

Changes

  • Added initial docs for Galasa Ecosystem admins on how to rotate encryption keys using the rotate-encryption-keys script
  • Updated docs about setting credentials to use the new galasactl secrets commands rather than manually logging into the etcd pod and setting credentials that way
  • Updated docs for managing Galasa resources using galasactl resources commands to include the new GalasaSecret resource type

@eamansour eamansour mentioned this pull request Nov 4, 2024
Merged
@eamansour eamansour force-pushed the iss1467-encryption-docs branch from e7a7a0d to 12c582a Compare November 4, 2024 13:18
jt-nti
jt-nti previously approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@jt-nti jt-nti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. Just a couple of thoughts...

  • I'm not entirely sure about using "CREDS" instead of just "credentials store" each time
  • Linking to an unversioned/unreleased shell script doesn't seem ideal but that's bigger than a doc review :)

jt-nti
jt-nti previously approved these changes Nov 14, 2024
View reviewed changes
@eamansour
fix: Replace links to specific released helm chart versions with link…
ce6f6c7 
…s to helm the releases page

Signed-off-by: Eamonn Mansour <[email protected]>
@jt-nti jt-nti merged commit 459c25e into galasa-dev:next Nov 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jt-nti jt-nti jt-nti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eamansour @jt-nti