Updating FontAwesome Icons in Admin area #3193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some FontAwesome icons do not work properly when other extensions are added to Joomla. These changes are for compatability with newer versions of Joomla and FontAwesome 5. Some important icons get broken sometimes arrows for the spacer particle TM (trademark) for the branding particle For other particles that utilize the pencil, copy, trash FA icons For the Branding particle located in: engines\common\nucleus\particles branding.yaml branding.html.twig In the Gantry 5 it has the class "fa fa-fw fa-trademark" on the left side menu of particles but "fas fa-fw fa-trademark" is more compatible. When the branding particle is added to a layout, it again has the class "fa fa-trademark", and changing it to "fas fa-trademark" fixes the problem. However, I'm unable to figure out where to make these changes for this particle so it displays properly. I am uanble to pinpoint exactly what extensions trigger this issue but I do know making these changes fixes it and the changes are still compatible with a fresh install of Gantry 5. Just need to fix the Branding particle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some FontAwesome icons do not work properly when J2Store is added to Joomla. This happens whether in J3 or J4. These changes are for compatibility with newer versions of Joomla and FontAwesome 5.
J2Store can be downloaded for free from here:
https://github.com/J2Store4/j2store4/releases
Icons that get broken:
For the Branding particle located in:
engines\common\nucleus\particlesand the files
branding.yamlbranding.html.twigIn Gantry 5 the branding particle has the class
fa fa-fw fa-trademarkon the left side menu of particles butfas fa-fw fa-trademarkis more compatible. When the branding particle is added to a layout, it again has the classfa fa-trademark, and changing it tofas fa-trademarkfixes the problem. However, I'm unable to figure out where to make these changes for this particle so it displays properly.These changes fix the issue and they are still compatible with a fresh install of Gantry 5. Just need to fix the Branding particle.