Keymaps improvements

[axbmcuser]

Some very few but effective keymaps improvements which could go along especially well with the latest GameOSD UI updates.

If i see correctly, as of today, on controllers, GameOSD can be opened (and closed) in at least 3 ways:

• Xbox/PS Button
• Select + X (Speaking in Xbox button namings; =left face button)
• Select + Y (Speaking in Xbox button namings; =top face button)
• Long hold "Start"

I changed "Select + X" and "Select + Y" to only "Select + A" because:

• Having too many ways to reach the same navigation goal is sometimes more confusing than helpful. Less can be more
• The change to "Select + A" came to mind because i found it ergonomically easier to access and also with the general idea in mind that in rare cases there might be a controller which only has 2 face buttons and therefore does not have a "X" or "Y" button for this combo.

Feel free to correct if i overlooked anything or something else comes to mind.

Cheers

[axbmcuser]

https://kodi.wiki/view/Game_playback_controls

Now that i just read that the "Select+Y" (Xbox style = Select+X in SNES style) Game Menu toggle might be adapted from RetroPie - if that's a button combo that's already common and well established, i surely will re-add it back in an updated commit. Did not know about that.

Everything else should still be valid.

Will read some more since i never used RetroPie yet (or even Kodi RetroPlayer until recently). :-)

Edit:
Re-added "Select+Y" (Xbox style) like in RetroPie. Will change the skins Info screen to reflect the change on next update.
Won't re-add Select+X (Xbox style) since that seems to be the very much needed button combo for mainline MAME menu.

[garbear]

Thanks for the keymap recommendations!

Regarding the Select X/Y action, you can see how you have to specify each style whenever referring to the controls. More broadly, the two styles are "Western" (xbox) and "Japanese" (snes/ps). We can certainly extend the keymap system to be conscious of these so that the correct button is mapped and labelled in the GUI. However, as I haven't completed this task, I just made both X and Y do the same thing. At the expense of some confusion due to multiple actions having the same effect, you can't argue that it doesn't solve the problem effectively.

A parallel task that we can consider is the discussion in xbmc#25178: Android controller support is majorly screwed up for remotes and controllers, so I'd like to combine them into a single map. Maybe we can consider this desire in our effort to improve button maps?

Re-added "Select+Y" (Xbox style) like in RetroPie. Will change the skins Info screen to reflect the change on next update.
Won't re-add Select+X (Xbox style) since that seems to be the very much needed button combo for mainline MAME menu.

I can support you by adding a new feature, the ability to show "real" buttons in the UI. I started this effort here: xbmc#24147. It can be made more expressive to show other info dynamically (such as even highlighting button labels when the button is pressed, similar to how the controller icons are activated in the Player Viewer).

Does xbmc#24147 open up any ideas on your end?