support dockerd and docker daemon in unit files #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…where systemd cannot start contemporary versions of docker with the docker unit file because it calls out the now deprecated `docker dameon`
|
Works well on docker >= v1.12.1 |
|
I'm no mantainer but, couldn't this be more easily done just assigning proper default values in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
docker daemonhas been deprecated since docker v1.13. This means that if you are using a recent version of docker, the unit files for upstart and systemd call the deprecated binary that is not installed. However, for people running older versions of docker, usingdocker daemonis correct. In this pull request I am adding support for people usingdockerd. Here is a related issue #701.