Escape all C0 and C1 control codes under escape_chars => 'nonascii' #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Along the way consolidates the five escaping passes in _escape_chars into a single substitution, with the side effect of causing print_escapes to not generate redundant color-switch codes.
|
Hi @sorear! Thanks for taking the time to write this PR and many apologies for the very (very!) long wait. The code has changed a lot so I can't merge this cleanly anymore (sorry!) However, before I try to come up with an updated fix, let me ask you: since your patch is related to #101, how do you feel about it. What sort of interface are you looking for when viewing that kind of data? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along the way consolidates the five escaping passes in _escape_chars into a
single substitution, with the side effect of causing print_escapes to not
generate redundant color-switch codes.
(because it's quite annoying to dump a five-page data structure, then not be able to read it because somewhere near the beginning was a 0/14 SHIFT OUT switching my terminal to VT100 graphics mode.)