Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for propagate #134

Open
wants to merge 3 commits into
base: ag-propagatebind
Choose a base branch
from

Conversation

GuusAvis
Copy link

@GuusAvis GuusAvis commented Aug 5, 2024

Added two new tests of propagate that check if finite perturbations returned by functions upon normal calls are treated correctly by propagate.

  1. Adding two stochastic triples together, like in stochastic triples not passed through propagate lose their perturbations #128 (comment); the way I'm constructing the stochastic triples may be nonstandard/bad practice though.
  2. Step-game-like example that @gaurav-arya provided in Make propagate more like a monadic bind by supporting stochastic triple creating functions #132. It's a statistical test so it can fail, but I set some pretty wide margins (basically 10 sigma) so it should be quite rare I think. Let me know if this is what you had in mind.

I'm open to suggestions!

I expect the tests for this PR to fail because there are still the issues in #133 , probably that should be dealt with first before looking more closely at this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant