document fix for #273 - use working weights in partial residuals

gavinsimpson · Oct 19, 2024 · 6fcf0e8 · 6fcf0e8
1 parent 004e72c
commit 6fcf0e8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,5 +1,5 @@
 Package: gratia
-Version: 0.9.2.9009
+Version: 0.9.2.9010
 Title: Graceful 'ggplot'-Based Graphics and Other Functions for GAMs Fitted Using 'mgcv'
 Authors@R: c(person(given = "Gavin L.", family = "Simpson",
                     email = "[email protected]",

diff --git a/NEWS.md b/NEWS.md
@@ -29,6 +29,12 @@
 * `derivatives()` would fail for `"fs"` smooths with other parametric effects in
   the model. Reported by @mahonmb #301
 
+* Partial residuals in `partial_residuals()` and `draw.gam()` were wrong for
+  GAMs fitted with `family = binomial()` where the `weights` argument contained
+  the binomial sample sizes because the prior weights were being used to form
+  weighted working residuals. Now working weights are used instead. Reported by
+  @emchuron #273
+
 # gratia 0.9.2
 
 ## Breaking changes