add grpc-web gateways for REST access to Journal and Shard APIs #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the `github.com/grpc-ecosystem/grpc-gateway` project to automatically generate REST handlers for portions of the Journals and Shards gRPC services. Also implement a CORS wrapper with configurable allowed origins. Together these changes allow Gazette brokers and consumers to be directly queried by browsers in cross-origin contexts. Note that REST handlers automatically forward `Authorization: Bearer` tokens into their corresponding gRPC handlers, so authorization checks "just work".
jgraettinger
force-pushed
the
johnny/grpc-web
branch
from
38108ff
to
90f91e3
Compare
Allow consumers applications to provide a function which wraps around a raw net.Listener and a loaded *tls.Config, returning another net.Listener, in order to customize the manner in which net.Conn instances are accepted and built.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
github.com/grpc-ecosystem/grpc-gatewayproject to automatically generate REST handlers for portions of the Journals and Shards gRPC services.Also implement a CORS wrapper with configurable allowed origins. Together these changes allow Gazette brokers and consumers to be directly queried by browsers in cross-origin contexts.
Note that REST handlers automatically forward
Authorization: Bearertokens into their corresponding gRPC handlers, so authorization checks "just work".This change is