Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Change to nginx-unprivileged image for better kubernetes support #1922

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hsolberg
Copy link

@hsolberg hsolberg commented Oct 8, 2024

Solves #1880

Not sure which image-repo you prefer to use, it's using Docker Hub in the pull-request (should be fine since its from a "Verified Publisher" and thus does not count towards the rate limit).

Alternative sources can be found here
Amazon ECR - https://gallery.ecr.aws/nginx/nginx-unprivileged
Docker Hub - https://hub.docker.com/r/nginxinc/nginx-unprivileged
GitHub Container Registry - https://github.com/nginxinc/docker-nginx-unprivileged/pkgs/container/nginx-unprivileged
Quay - https://quay.io/repository/nginx/nginx-unprivileged

@hsolberg hsolberg marked this pull request as draft October 8, 2024 09:43
@hsolberg
Copy link
Author

hsolberg commented Oct 8, 2024

Originally encountered a problem with the ChromeDriver version that's been addressed in d3adfc7 , expand to show the context if needed.

UI Test fails with the error below. Seems a lot of pull-requests are facing the same issue.

>> - Starting ChromeDriver on port 9515...
>> Error
>>      Response 500 POST /session (28155ms)
   {
     value: {
       error: 'session not created',
       message: 'session not created: This version of ChromeDriver only supports Chrome version 127\n' +
         'Current browser version is 129.0.6668.58 with binary path /opt/google/chrome/chrome',
       stacktrace: ''
     }
  }
>> Error

@hsolberg hsolberg marked this pull request as ready for review October 8, 2024 11:01
@Kaurin
Copy link

Kaurin commented Oct 28, 2024

Have these tests been fixed?

@hsolberg hsolberg force-pushed the feature/change-to-nginx-unprivileged branch from 8fdc311 to 32dda5b Compare October 28, 2024 08:15
@hsolberg
Copy link
Author

Have these tests been fixed?

Seem to work now after rebasing. Looks like this commit addressed the issue -> d3adfc7

@Kaurin
Copy link

Kaurin commented Oct 28, 2024

You might want to change the docker commandline in the readme so it shows forwarding to the new default ports of 8080 instead of the previous 80:

docker run -it -p 8080:8080 cyberchef

and

docker run -it -p 8080:8080 ghcr.io/gchq/cyberchef:latest

As per: https://hub.docker.com/r/nginxinc/nginx-unprivileged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants