Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for definition xrefs that are not also term xrefs #29161

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add check for definition xrefs that are not also term xrefs #29161

wants to merge 2 commits into from
+28 −1

Conversation

balhoff
Copy link
Member

@balhoff balhoff commented Nov 6, 2024 •
edited by pgaudet
Loading

Google spreadsheet: https://docs.google.com/spreadsheets/d/1jMfBoiSRrT-Ycx6TEA9laLDLL9Tj1cFqp9V9WX3mcyk/edit?gid=0#gid=0

Fixes #28523.

In order to be merged, these all need to be checked. @pgaudet is there anything I can do to automate this?

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

Here's a diff of how these changes impact the classified ontology:

Ontologies are identical

@balhoff
Copy link
Member Author

balhoff commented Nov 6, 2024

@pgaudet I tried automatically copying these def xrefs to term xrefs, but there were a large number of one-to-one mapping violations in QC. So I decided to leave the list as is rather than creating additional changes to manage.

pgaudet added a commit that referenced this pull request Nov 13, 2024
@pgaudet
fixed xef for #29161
10169dd
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
Merged
@balhoff balhoff force-pushed the issue-28523 branch 2 times, most recently from de34b5a to 0cde52c Compare December 4, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add check for database definition cross references to also be a general cross reference
1 participant
@balhoff